serve workflow templates from custom_nodes #6193
Open
+85
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Dec 24, 2024
server.py
Outdated
| @@ -250,6 +250,16 @@ async def get_extensions(request): | |||
| name) + "/" + os.path.relpath(f, dir).replace("\\", "/"), files))) | |||
|
|
|||
| return web.json_response(extensions) | |||
|
|
|||
| @routes.get("/workflow_templates") | |||
There was a problem hiding this comment.
We do have a plan to eventually move ComfyUI-Manager's custom node management features to core. Can we move this endpoint to a separate file app/custom_node_manager.py?
server.py
Outdated
|
|
||
| @routes.get("/workflow_templates") | ||
| async def get_workflow_templates(request): | ||
| files = glob.glob(os.path.join(folder_paths.custom_nodes_directory, '*/example_workflows/*.json')) |
There was a problem hiding this comment.
I think you can just call folder_paths.get_folder_paths("custom_nodes") here instead of adding a new global variable in folder_paths.
bezo97
requested review from
yoland68,
robinjhuang,
webfiltered,
pythongosssss,
ltdrdata and
Kosinkadink
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the following feature request: Comfy-Org/ComfyUI_frontend#1008
Related frontend PR: Comfy-Org/ComfyUI_frontend#2032
Implementation details:
@routes.get("/workflow_templates")- This endpoint returns a map of custom_nodes names and their associated workflow template files. The ones without templates are omitted. Example:LOADED_MODULE_DIRSwhere we keep track of all successfully loaded custom_nodes and their directories (even when there is no class mapping and web directory)custom_nodes/*/example_workflows/*Question to reviewers:
/example_workflowsfolders sufficient or shall we support existing folder structures of popular custom_node repos by allowing/examples,/workflows, etc.?